Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackdriver dashboards resource #3490

Merged

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#5124.

Release Note Template for Downstream PRs (will be copied)

`google_monitoring_dashboard`
The base url for the `monitoring` endpoint no longer includes the API version (previously "v3/"). If you use a `monitoring_custom_endpoint`, remove the trailing "v3/".

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-))
TF Conversion: Diff ( 7 files changed, 19 insertions(+), 19 deletions(-))
Inspec: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-))
TF Conversion: Diff ( 7 files changed, 19 insertions(+), 19 deletions(-))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produced incorrect results here:

https://github.com/modular-magician/terraform-google-conversion/compare/auto-pr-3490-old..auto-pr-3490

The version of monitoring resources is now being listed as the base URL.

I personally don't know if that matters, but it's the only issue / error I saw - if you are interested in fixing it, lmk and I'll review again. Otherwise, LGTM.

@nat-henderson
Copy link
Contributor

For sure it breaks the library for those resources - I just don't know if those resources are actually published or have users, or how hard it would be to fix those resources.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-))
TF Conversion: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@danawillow
Copy link
Contributor Author

Fixed it! I'm going to go ahead and merge now since the conversion repo looks totally fine and good. I don't think they actually have users- CAI doesn't seem to support monitoring as one of the things you can do stuff with, so I don't think it really matters, but figured it was worth fixing anyway in case they want to do something with it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackdriver Dashboards
4 participants